Conversation
When a session ID is supplied via cookie but has no corresponding server-side data, generate a new ID instead of accepting the unknown one. This prevents session fixation where an attacker pre-sets a known session ID in the victim's cookie.
* refactor astro-attrs.test.js to unit tests * fix indent * remove the space before the `addAttribute` function * update to match the latest `astro-attrs.test.js`
…#15744) * Improve cookie handling consistency in error page responses * fix(lint): remove useless lazy quantifiers in test regex patterns --------- Co-authored-by: astro-security-bot <astro-security-bot@users.noreply.github.com>
* Harden X-Forwarded-For to respect allowedDomains for clientAddress * fix(test): add allowedDomains to client-address-node fixture for XFF trust
* fix: cloudflare adapter respects static output for fully prerendered sites * feat: add preserveDirectoryStructure adapter feature - Allows adapters to preserve client/server directory structure for static builds - Cloudflare adapter now uses this to maintain consistent deployment structure - Fixes issues with static site deployments expecting specific directory layout * build issue * fix: always use server buildOutput for cloudflare adapter The static buildOutput path doesn't inject the manifest into the Cloudflare worker entry.mjs, since it's built by the Cloudflare vite plugin separately and isn't included in the chunks array that manifestBuildPostHook processes. Use 'server' always as a workaround. * rename preserveDirectoryStructure to preserveBuildClientDir * Update .changeset/fix-cloudflare-static-output.md Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> * Update .changeset/preserve-directory-structure.md Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> * test: add unit tests for preserveBuildClientDir adapter feature --------- Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )